Streamline deployment of GESIS acceptance server #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jupyter Hub and Binder Hub uses ingressClassName instead of className.
as indicated in https://helm.sh/docs/chart_best_practices/templates/#comments-yaml-comments-vs-template-comments to pass Helm lint.
because it is already present.
rgaiacs
force-pushed
the
gesis-methods-hub
branch
from
75b3ca0 to
9823278
Compare
|
This is ready for review. If it looks good, please merge. The @arnim this does not include the custom GESIS page. This will go in another PR. |
rgaiacs
force-pushed
the
gesis-methods-hub
branch
from
def6a62 to
ec006f7
Compare
|
I think this is fine- though would you mind minimising the changes to the templates, or alternatively put the reformatting into a separate PR and ideally add whatever formatter you're using to pre-commit? |
I will do at the end of the month. Busy with a couple of things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related with #2797 and #3087.
SSH access to GESIS Kubernetes cluster requires access to GESIS VPN. This makes the use of GitHub actions challenge.
Different than #3090, this PR assumes that the GESIS Kubernetes is configured. GESIS Kubernetes runs on bare-metal and is configured following MetalLB + Ingress NGINX Controller.
GESIS operates a on-premise GitLab. This PR addes a GitLab CI/CD configuration to deploy the mybinder.org Helm chart to the GESIS Kubernetes using GitLab agent for Kubernetes.
After #3159, any the commit on
mainis pushed to GESIS GitLab and will trigger a new deployment of this mybinder.org Helm chart.At the moment, the Helm chart deploy fails with
My understanding of the error is that GESIS Kubernetes already has a Ingress Class
nginxthat was configured for MetalLB + Ingress NGINX Controller but the Binder Hub and Jupyter Hub upstream Helm chart tries to create the same Ingress Classnginxand this operation is blocked. Is my understanding correct? @manics @yuvipanda @minrk